<p><a href="https://review.coreboot.org/25663">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c">File src/device/dram/ddr3.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c@298">Patch Set #1, Line 298:</a> <code style="font-family:monospace,monospace">     /* Minimum CAS Write Latency Time (tCWLmin)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">over line</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c@491">Patch Set #1, Line 491:</a> <code style="font-family:monospace,monospace">   /* CAS Latencies Supported */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">According to spec 1.1 it's  […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25663/2/src/device/dram/ddr3.c">File src/device/dram/ddr3.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25663/2/src/device/dram/ddr3.c@584">Patch Set #2, Line 584:</a> <code style="font-family:monospace,monospace">                print_ns("  tCMDmin           : ", dimm->tCMD);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">It's not in units of ns, but tCK/ns</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should I add a function along the lines of print_tck for this?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25663">change 25663</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25663"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie4f545ed1df92c146be02f56fea0ca9037478649 </div>
<div style="display:none"> Gerrit-Change-Number: 25663 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Dan Elkouby <streetwalkermc@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Dan Elkouby <streetwalkermc@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 14 Apr 2018 10:58:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>