[coreboot-gerrit] Change in coreboot[master]: nb/intel/sandybridge: support more XMP timings

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/25664 )

Change subject: nb/intel/sandybridge: support more XMP timings
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/25664/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/25664/1//COMMIT_MSG@8
PS1, Line 8: 
How did you test it ?
Why introduce the change ?
Does it improve performance or stability ?


https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_common.c
File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_common.c@2362
PS1, Line 2362: 			cmdrate = MIN(DIV_ROUND_UP(ctrl->tCMD, ctrl->tCK) - 1, 1);
As long as you can't prove that it'll work on any board (see comment above): No.

I would accept cmdrate = MAX(cmdrage, DIV_ROUND_UP(ctrl->tCMD, ctrl->tCK));

Also please make sure that DIV_ROUND_UP(ctrl->tCMD, ctrl->tCK) never exceeds 2.


https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_ivy.c
File src/northbridge/intel/sandybridge/raminit_ivy.c:

https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_ivy.c@485
PS1, Line 485: 		ctrl->CWL = get_CWL(ctrl->tCK);
why not 
MAX(get_CWL(ctrl->tCK), DIV_ROUND_UP(ctrl->tCWL, ctrl->tCK)) ?



-- 
To view, visit https://review.coreboot.org/25664
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I634bed764d76345c27f02a2fae5abb2d81b38fd9
Gerrit-Change-Number: 25664
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Elkouby <streetwalkermc at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Sat, 14 Apr 2018 09:45:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180414/fba3d221/attachment.html>