<p><a href="https://review.coreboot.org/25664">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25664/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25664/1//COMMIT_MSG@8">Patch Set #1, Line 8:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">How did you test it ?<br>Why introduce the change ?<br>Does it improve performance or stability ?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_common.c">File src/northbridge/intel/sandybridge/raminit_common.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_common.c@2362">Patch Set #1, Line 2362:</a> <code style="font-family:monospace,monospace">                       cmdrate = MIN(DIV_ROUND_UP(ctrl->tCMD, ctrl->tCK) - 1, 1);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">As long as you can't prove that it'll work on any board (see comment above): No.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I would accept cmdrate = MAX(cmdrage, DIV_ROUND_UP(ctrl->tCMD, ctrl->tCK));</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also please make sure that DIV_ROUND_UP(ctrl->tCMD, ctrl->tCK) never exceeds 2.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_ivy.c">File src/northbridge/intel/sandybridge/raminit_ivy.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/25664/1/src/northbridge/intel/sandybridge/raminit_ivy.c@485">Patch Set #1, Line 485:</a> <code style="font-family:monospace,monospace">               ctrl->CWL = get_CWL(ctrl->tCK);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why not <br>MAX(get_CWL(ctrl->tCK), DIV_ROUND_UP(ctrl->tCWL, ctrl->tCK)) ?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/25664">change 25664</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25664"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I634bed764d76345c27f02a2fae5abb2d81b38fd9 </div>
<div style="display:none"> Gerrit-Change-Number: 25664 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Dan Elkouby <streetwalkermc@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-CC: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 14 Apr 2018 09:45:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>