[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Print types on stdout
Martin Roth (Code Review)
gerrit at coreboot.org
Wed Apr 11 16:11:20 CEST 2018
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/25589 )
Change subject: util/cbfstool: Print types on stdout
......................................................................
util/cbfstool: Print types on stdout
Currently, "cbfstool -h | less" doesn't show any file types under
"TYPEs:". That's because the file types are printed with
print_supported_filetypes, which uses LOG, which prints to stderr. Use
printf print_supported_filetypes, and thus print to stdout, to make the
usage output more normal.
Change-Id: I800c9205c59383b63a640bc0798a1bd9117b0f99
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Reviewed-on: https://review.coreboot.org/25589
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M util/cbfstool/common.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Patrick Georgi: Looks good to me, approved
diff --git a/util/cbfstool/common.c b/util/cbfstool/common.c
index 5a47c2f..72ff745 100644
--- a/util/cbfstool/common.c
+++ b/util/cbfstool/common.c
@@ -173,9 +173,9 @@
int i, number = ARRAY_SIZE(filetypes);
for (i=0; i<number; i++) {
- LOG(" %s%c", filetypes[i].name, (i==(number-1))?'\n':',');
+ printf(" %s%c", filetypes[i].name, (i==(number-1))?'\n':',');
if ((i%8) == 7)
- LOG("\n");
+ printf("\n");
}
}
--
To view, visit https://review.coreboot.org/25589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I800c9205c59383b63a640bc0798a1bd9117b0f99
Gerrit-Change-Number: 25589
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180411/58887c5a/attachment.html>
More information about the coreboot-gerrit
mailing list