<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/25589">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">util/cbfstool: Print types on stdout<br><br>Currently, "cbfstool -h | less" doesn't show any file types under<br>"TYPEs:". That's because the file types are printed with<br>print_supported_filetypes, which uses LOG, which prints to stderr.  Use<br>printf print_supported_filetypes, and thus print to stdout, to make the<br>usage output more normal.<br><br>Change-Id: I800c9205c59383b63a640bc0798a1bd9117b0f99<br>Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net><br>Reviewed-on: https://review.coreboot.org/25589<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Patrick Georgi <pgeorgi@google.com><br>---<br>M util/cbfstool/common.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/util/cbfstool/common.c b/util/cbfstool/common.c</span><br><span>index 5a47c2f..72ff745 100644</span><br><span>--- a/util/cbfstool/common.c</span><br><span>+++ b/util/cbfstool/common.c</span><br><span>@@ -173,9 +173,9 @@</span><br><span>    int i, number = ARRAY_SIZE(filetypes);</span><br><span> </span><br><span>   for (i=0; i<number; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-           LOG(" %s%c", filetypes[i].name, (i==(number-1))?'\n':',');</span><br><span style="color: hsl(120, 100%, 40%);">+          printf(" %s%c", filetypes[i].name, (i==(number-1))?'\n':',');</span><br><span>              if ((i%8) == 7)</span><br><span style="color: hsl(0, 100%, 40%);">-                 LOG("\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                  printf("\n");</span><br><span>      }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25589">change 25589</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25589"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I800c9205c59383b63a640bc0798a1bd9117b0f99 </div>
<div style="display:none"> Gerrit-Change-Number: 25589 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer@gmx.net> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>