[coreboot-gerrit] Change in coreboot[master]: fsp_broadwell_de: Provide valid address and size for DCACHE range

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/25535


Change subject: fsp_broadwell_de: Provide valid address and size for DCACHE range
......................................................................

fsp_broadwell_de: Provide valid address and size for DCACHE range

On Broadwell-DE the FSP sets up DCACHE in the early call. The address
does not match the default FSP 1.0 address defined in
src/drivers/intel/fsp1_0/Kconfig which leads to errors when this range
is used in pre-ramstage stages.

This patch provides the matching DCACHE_RAM_BASE value among with a
suitable DCACHE_RAM_SIZE for the FSP based Broadwell-DE implementation.
The include order of Kconfig files makes sure that the Kconfig file in
the soc directory is sourced first and the defined values will override
the ones in src/drivers/intel/fsp1_0/Kconfig.

Change-Id: I2a55b576541a3d974ee2714b198095aa24fc46f5
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/soc/intel/fsp_broadwell_de/fsp/Kconfig
1 file changed, 16 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/25535/1

diff --git a/src/soc/intel/fsp_broadwell_de/fsp/Kconfig b/src/soc/intel/fsp_broadwell_de/fsp/Kconfig
index 2e1ebeb..4301be5 100644
--- a/src/soc/intel/fsp_broadwell_de/fsp/Kconfig
+++ b/src/soc/intel/fsp_broadwell_de/fsp/Kconfig
@@ -21,6 +21,22 @@
 	  The Broadwell-DE FSP is built with a preferred base address of
 	  0xffeb0000.
 
+config DCACHE_RAM_BASE
+	hex
+	default 0xfe100000
+	help
+	  This address needs to match the setup performed inside FSP.
+	  On Broadwell-DE the FSP allocates temporary RAM starting at 0xfe100000.
+
+config DCACHE_RAM_SIZE
+	hex
+	default 0x8000
+	help
+	  The DCACHE is shared between FSP itself and the rest of the coreboot
+	  stages. A size of 0x8000 works fine while provides enough space for
+	  features like VBOOT in verstage. Further increase to a power of two align
+	  value leads to errors in FSP.
+
 config FSP_MEMORY_DOWN
 	bool "Enable Memory Down"
 	default n

-- 
To view, visit https://review.coreboot.org/25535
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a55b576541a3d974ee2714b198095aa24fc46f5
Gerrit-Change-Number: 25535
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180405/5a2758b1/attachment-0001.html>