[coreboot-gerrit] Change in coreboot[master]: [NEEDS TESTING] sb/intel/common/firmware: Use the -S flag of me_cleaner

[Nicola Corna (Code Review)]

Nicola Corna has uploaded this change for review. ( https://review.coreboot.org/25508


Change subject: [NEEDS TESTING] sb/intel/common/firmware: Use the -S flag of me_cleaner
......................................................................

[NEEDS TESTING] sb/intel/common/firmware: Use the -S flag of me_cleaner

The -S flag of me_cleaner, in addition to the standard code removal,
sets the the AltMeDisable bit (ME 6.x-10.x) or the HAP bit (ME 11.x),
which ask Intel ME to stop the execution after the hardware
initialization.

This should bring some advantages:
 * The state of Intel ME can be easily obtained by reading the Current
    Operation Mode register to trigger specific adjustments in the
    raminit (as already done in bd82x6x)
 * Intel ME falls into a more defined state, instead of being in a
    generic "Image Failure"
 * Hopefully, less code is run by Intel ME, as the execution should
    stop even before trying to load additional modules

Tested on Sandy/Ivy Bridge, but should be tested on all the generations
to be sure it doesn't introduce boot delays.

Change-Id: I2c12d09124dcc39924d1dc4eaf53a2dc1f69a2ac
Signed-off-by: Nicola Corna <nicola at corna.info>
---
M src/southbridge/intel/common/firmware/Makefile.inc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/25508/1

diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.inc
index d6e6296..ebdb03b 100644
--- a/src/southbridge/intel/common/firmware/Makefile.inc
+++ b/src/southbridge/intel/common/firmware/Makefile.inc
@@ -63,7 +63,7 @@
 endif
 ifeq ($(CONFIG_USE_ME_CLEANER),y)
 	printf "    ME_CLEANER coreboot.pre\n"
-	util/me_cleaner/me_cleaner.py $(obj)/coreboot.pre > \
+	util/me_cleaner/me_cleaner.py -S $(obj)/coreboot.pre > \
 		$(obj)/me_cleaner.log
 endif
 ifeq ($(CONFIG_HAVE_GBE_BIN),y)

-- 
To view, visit https://review.coreboot.org/25508
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c12d09124dcc39924d1dc4eaf53a2dc1f69a2ac
Gerrit-Change-Number: 25508
Gerrit-PatchSet: 1
Gerrit-Owner: Nicola Corna <nicola at corna.info>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180403/9decedc4/attachment.html>