<p>Nicola Corna has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/25508">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[NEEDS TESTING] sb/intel/common/firmware: Use the -S flag of me_cleaner<br><br>The -S flag of me_cleaner, in addition to the standard code removal,<br>sets the the AltMeDisable bit (ME 6.x-10.x) or the HAP bit (ME 11.x),<br>which ask Intel ME to stop the execution after the hardware<br>initialization.<br><br>This should bring some advantages:<br> * The state of Intel ME can be easily obtained by reading the Current<br>    Operation Mode register to trigger specific adjustments in the<br>    raminit (as already done in bd82x6x)<br> * Intel ME falls into a more defined state, instead of being in a<br>    generic "Image Failure"<br> * Hopefully, less code is run by Intel ME, as the execution should<br>    stop even before trying to load additional modules<br><br>Tested on Sandy/Ivy Bridge, but should be tested on all the generations<br>to be sure it doesn't introduce boot delays.<br><br>Change-Id: I2c12d09124dcc39924d1dc4eaf53a2dc1f69a2ac<br>Signed-off-by: Nicola Corna <nicola@corna.info><br>---<br>M src/southbridge/intel/common/firmware/Makefile.inc<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/25508/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.inc</span><br><span>index d6e6296..ebdb03b 100644</span><br><span>--- a/src/southbridge/intel/common/firmware/Makefile.inc</span><br><span>+++ b/src/southbridge/intel/common/firmware/Makefile.inc</span><br><span>@@ -63,7 +63,7 @@</span><br><span> endif</span><br><span> ifeq ($(CONFIG_USE_ME_CLEANER),y)</span><br><span>   printf "    ME_CLEANER coreboot.pre\n"</span><br><span style="color: hsl(0, 100%, 40%);">-        util/me_cleaner/me_cleaner.py $(obj)/coreboot.pre > \</span><br><span style="color: hsl(120, 100%, 40%);">+      util/me_cleaner/me_cleaner.py -S $(obj)/coreboot.pre > \</span><br><span>          $(obj)/me_cleaner.log</span><br><span> endif</span><br><span> ifeq ($(CONFIG_HAVE_GBE_BIN),y)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/25508">change 25508</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/25508"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I2c12d09124dcc39924d1dc4eaf53a2dc1f69a2ac </div>
<div style="display:none"> Gerrit-Change-Number: 25508 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Nicola Corna <nicola@corna.info> </div>