[coreboot-gerrit] Change in coreboot[master]: siemens/nc_fpga: Move some parameters to another function

[Mario Scheithauer (Code Review)]

Mario Scheithauer has uploaded this change for review. ( https://review.coreboot.org/21694


Change subject: siemens/nc_fpga: Move some parameters to another function
......................................................................

siemens/nc_fpga: Move some parameters to another function

For general use of this driver it is necessary to move some parameters
from init_fan_ctrl() to init_temp_mon(). This shift does not lead to any
functional change.

Change-Id: I6b8f770c768f3dacf96087eb0194cc99f0d11e17
Signed-off-by: Mario Scheithauer <mario.scheithauer at siemens.com>
---
M src/drivers/siemens/nc_fpga/nc_fpga.c
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/21694/1

diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c
index 61d9e08..28fc6e2 100644
--- a/src/drivers/siemens/nc_fpga/nc_fpga.c
+++ b/src/drivers/siemens/nc_fpga/nc_fpga.c
@@ -53,6 +53,11 @@
 		}
 	}
 	ctrl->sensornum = num;
+
+	/* Program sensor selection and temperature thresholds. */
+	FPGA_SET_PARAM(FANSensorSelect, ctrl->sensorselect);
+	FPGA_SET_PARAM(T_Warn, ctrl->t_warn);
+	FPGA_SET_PARAM(T_Crit, ctrl->t_crit);
 }
 
 static void init_fan_ctrl (void *base_adr)
@@ -61,9 +66,6 @@
 	volatile fan_ctrl_t *ctrl = (fan_ctrl_t *)base_adr;
 
 	/* Program all needed fields of FAN controller. */
-	FPGA_SET_PARAM(FANSensorSelect, ctrl->sensorselect);
-	FPGA_SET_PARAM(T_Warn, ctrl->t_warn);
-	FPGA_SET_PARAM(T_Crit, ctrl->t_crit);
 	FPGA_SET_PARAM(FANSamplingTime, ctrl->samplingtime);
 	FPGA_SET_PARAM(FANSetPoint, ctrl->setpoint);
 	FPGA_SET_PARAM(FANHystCtrl, ctrl->hystctrl);

-- 
To view, visit https://review.coreboot.org/21694
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b8f770c768f3dacf96087eb0194cc99f0d11e17
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170926/9d8d60ed/attachment.html>