<p>Mario Scheithauer has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21694">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">siemens/nc_fpga: Move some parameters to another function<br><br>For general use of this driver it is necessary to move some parameters<br>from init_fan_ctrl() to init_temp_mon(). This shift does not lead to any<br>functional change.<br><br>Change-Id: I6b8f770c768f3dacf96087eb0194cc99f0d11e17<br>Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com><br>---<br>M src/drivers/siemens/nc_fpga/nc_fpga.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/21694/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/drivers/siemens/nc_fpga/nc_fpga.c b/src/drivers/siemens/nc_fpga/nc_fpga.c<br>index 61d9e08..28fc6e2 100644<br>--- a/src/drivers/siemens/nc_fpga/nc_fpga.c<br>+++ b/src/drivers/siemens/nc_fpga/nc_fpga.c<br>@@ -53,6 +53,11 @@<br>              }<br>     }<br>     ctrl->sensornum = num;<br>+<br>+ /* Program sensor selection and temperature thresholds. */<br>+   FPGA_SET_PARAM(FANSensorSelect, ctrl->sensorselect);<br>+      FPGA_SET_PARAM(T_Warn, ctrl->t_warn);<br>+     FPGA_SET_PARAM(T_Crit, ctrl->t_crit);<br> }<br> <br> static void init_fan_ctrl (void *base_adr)<br>@@ -61,9 +66,6 @@<br>       volatile fan_ctrl_t *ctrl = (fan_ctrl_t *)base_adr;<br> <br>        /* Program all needed fields of FAN controller. */<br>-   FPGA_SET_PARAM(FANSensorSelect, ctrl->sensorselect);<br>-      FPGA_SET_PARAM(T_Warn, ctrl->t_warn);<br>-     FPGA_SET_PARAM(T_Crit, ctrl->t_crit);<br>      FPGA_SET_PARAM(FANSamplingTime, ctrl->samplingtime);<br>       FPGA_SET_PARAM(FANSetPoint, ctrl->setpoint);<br>       FPGA_SET_PARAM(FANHystCtrl, ctrl->hystctrl);<br></pre><p>To view, visit <a href="https://review.coreboot.org/21694">change 21694</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21694"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6b8f770c768f3dacf96087eb0194cc99f0d11e17 </div>
<div style="display:none"> Gerrit-Change-Number: 21694 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Mario Scheithauer <mario.scheithauer@siemens.com> </div>