[coreboot-gerrit] Change in coreboot[master]: mainboard/google/soraka: Reduce Wacom resume time

[Rajneesh Bhardwaj (Code Review)]

Hello Anshuman Gupta,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/21692

to review the following change.


Change subject: mainboard/google/soraka: Reduce Wacom resume time
......................................................................

mainboard/google/soraka: Reduce Wacom resume time

Currently the WCOMCOHO registers a reset delay of 110ms to execute their
_ON_ asl power on method. This seems to be correct as per WACOM product
design specifications but it introduces an unwanted delay in overall system
resume time. This delay should be removed from ACPI critical path since the
entire kernel resume gets blocked on this sleep call unless this is over. In
the kernel I2C communication with WACOM driver starts with the resume
callbacks of I2C HID driver which gets triggered after display is completely
resumed. The display resume process takes at least 230ms so its safe to
reduce the delay from coreboot and unblock the critical ACPI path.

BUG=b:65358919
BRANCH=None
TEST=manual testing on Soraka board to ensue that touchscreen works at boot
and after suspend/resume. Also verify that the overall S3 resume time is
reduced by 100ms.

Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e
Signed-off-by: Anshuman Gupta <anshuman.gupta at intel.com>
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj at intel.com>
---
M src/mainboard/google/poppy/variants/soraka/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/21692/1

diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb
index b874093..93d9b7a 100644
--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb
@@ -224,7 +224,7 @@
 				register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"
 				register "generic.probed" = "1"
 				register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E3)"
-				register "generic.reset_delay_ms" = "110"
+				register "generic.reset_delay_ms" = "10"
 				register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"
 				register "generic.enable_delay_ms" = "1"
 				register "generic.has_power_resource" = "1"

-- 
To view, visit https://review.coreboot.org/21692
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e
Gerrit-Change-Number: 21692
Gerrit-PatchSet: 1
Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj at intel.com>
Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rajat Jain <rajatja at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar at intel.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170926/ed4bea18/attachment.html>