<p>Rajneesh Bhardwaj would like Anshuman Gupta to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/21692">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/soraka: Reduce Wacom resume time<br><br>Currently the WCOMCOHO registers a reset delay of 110ms to execute their<br>_ON_ asl power on method. This seems to be correct as per WACOM product<br>design specifications but it introduces an unwanted delay in overall system<br>resume time. This delay should be removed from ACPI critical path since the<br>entire kernel resume gets blocked on this sleep call unless this is over. In<br>the kernel I2C communication with WACOM driver starts with the resume<br>callbacks of I2C HID driver which gets triggered after display is completely<br>resumed. The display resume process takes at least 230ms so its safe to<br>reduce the delay from coreboot and unblock the critical ACPI path.<br><br>BUG=b:65358919<br>BRANCH=None<br>TEST=manual testing on Soraka board to ensue that touchscreen works at boot<br>and after suspend/resume. Also verify that the overall S3 resume time is<br>reduced by 100ms.<br><br>Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e<br>Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com><br>Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com><br>---<br>M src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/21692/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/poppy/variants/soraka/devicetree.cb b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>index b874093..93d9b7a 100644<br>--- a/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/soraka/devicetree.cb<br>@@ -224,7 +224,7 @@<br>                              register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"<br>                                 register "generic.probed" = "1"<br>                           register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E3)"<br>-                            register "generic.reset_delay_ms" = "110"<br>+                                register "generic.reset_delay_ms" = "10"<br>                          register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"<br>                          register "generic.enable_delay_ms" = "1"<br>                          register "generic.has_power_resource" = "1"<br></pre><p>To view, visit <a href="https://review.coreboot.org/21692">change 21692</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21692"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I59d070977a95316414018af69d5b43e3147ccf4e </div>
<div style="display:none"> Gerrit-Change-Number: 21692 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Anshuman Gupta <anshuman.gupta@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rajat Jain <rajatja@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar@intel.corp-partner.google.com> </div>