[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: [WIP] Add config for mbx command for Intersil VR C...

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/21680


Change subject: soc/intel/skylake: [WIP] Add config for mbx command for Intersil VR C-state issues
......................................................................

soc/intel/skylake: [WIP] Add config for mbx command for Intersil VR C-state issues

Config for activating VR mailbox command for Intersil VR C-state issues.
0 - no mailbox command sent.
1 - VR mailbox command sent for IA/GT rails only.
2 - VR mailbox command sent for IA/GT/SA rails.

Change-Id: Ibcced31b7ba473ffa7368c90c945d07a81a368d4
Signed-off-by: Rizwan Qureshi <rizwan.qureshi at intel.com>
---
M src/soc/intel/skylake/chip.h
M src/soc/intel/skylake/chip_fsp20.c
2 files changed, 16 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/21680/1

diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index 606078b..8c6e45a 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -518,6 +518,14 @@
 		/* coreboot handles locking */
 		CHIPSET_LOCKDOWN_COREBOOT,
 	} chipset_lockdown;
+
+	/*
+	 * Activates VR mailbox command for Intersil VR C-state issues.
+	 * 0 - no mailbox command sent.
+	 * 1 - VR mailbox command sent for IA/GT rails only.
+	 * 2 - VR mailbox command sent for IA/GT/SA rails.
+	 */
+	u8 IslVrCmd;
 };
 
 typedef struct soc_intel_skylake_config config_t;
diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c
index b1697ae..ac60125 100644
--- a/src/soc/intel/skylake/chip_fsp20.c
+++ b/src/soc/intel/skylake/chip_fsp20.c
@@ -271,6 +271,14 @@
 	 */
 	params->SendVrMbxCmd1 = config->SendVrMbxCmd;
 
+	/*
+	 * Activates VR mailbox command for Intersil VR C-state issues.
+	 * 0 - no mailbox command sent.
+	 * 1 - VR mailbox command sent for IA/GT rails only.
+	 * 2 - VR mailbox command sent for IA/GT/SA rails.
+	 */
+	params->IslVrCmd = config->IslVrCmd;
+
 	/* Acoustic Noise Mitigation */
 	params->AcousticNoiseMitigation = config->AcousticNoiseMitigation;
 	params->SlowSlewRateForIa = config->SlowSlewRateForIa;

-- 
To view, visit https://review.coreboot.org/21680
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcced31b7ba473ffa7368c90c945d07a81a368d4
Gerrit-Change-Number: 21680
Gerrit-PatchSet: 1
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170925/daebc051/attachment.html>