<p>Rizwan Qureshi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21680">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: [WIP] Add config for mbx command for Intersil VR C-state issues<br><br>Config for activating VR mailbox command for Intersil VR C-state issues.<br>0 - no mailbox command sent.<br>1 - VR mailbox command sent for IA/GT rails only.<br>2 - VR mailbox command sent for IA/GT/SA rails.<br><br>Change-Id: Ibcced31b7ba473ffa7368c90c945d07a81a368d4<br>Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com><br>---<br>M src/soc/intel/skylake/chip.h<br>M src/soc/intel/skylake/chip_fsp20.c<br>2 files changed, 16 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/21680/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h<br>index 606078b..8c6e45a 100644<br>--- a/src/soc/intel/skylake/chip.h<br>+++ b/src/soc/intel/skylake/chip.h<br>@@ -518,6 +518,14 @@<br>             /* coreboot handles locking */<br>                CHIPSET_LOCKDOWN_COREBOOT,<br>    } chipset_lockdown;<br>+<br>+       /*<br>+    * Activates VR mailbox command for Intersil VR C-state issues.<br>+       * 0 - no mailbox command sent.<br>+       * 1 - VR mailbox command sent for IA/GT rails only.<br>+  * 2 - VR mailbox command sent for IA/GT/SA rails.<br>+    */<br>+  u8 IslVrCmd;<br> };<br> <br> typedef struct soc_intel_skylake_config config_t;<br>diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c<br>index b1697ae..ac60125 100644<br>--- a/src/soc/intel/skylake/chip_fsp20.c<br>+++ b/src/soc/intel/skylake/chip_fsp20.c<br>@@ -271,6 +271,14 @@<br>        */<br>   params->SendVrMbxCmd1 = config->SendVrMbxCmd;<br> <br>+       /*<br>+    * Activates VR mailbox command for Intersil VR C-state issues.<br>+       * 0 - no mailbox command sent.<br>+       * 1 - VR mailbox command sent for IA/GT rails only.<br>+  * 2 - VR mailbox command sent for IA/GT/SA rails.<br>+    */<br>+  params->IslVrCmd = config->IslVrCmd;<br>+<br>         /* Acoustic Noise Mitigation */<br>       params->AcousticNoiseMitigation = config->AcousticNoiseMitigation;<br>      params->SlowSlewRateForIa = config->SlowSlewRateForIa;<br></pre><p>To view, visit <a href="https://review.coreboot.org/21680">change 21680</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21680"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ibcced31b7ba473ffa7368c90c945d07a81a368d4 </div>
<div style="display:none"> Gerrit-Change-Number: 21680 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>