[coreboot-gerrit] Change in coreboot[master]: device/dram/ddr2: Add break to several case statements that lack it

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/21642


Change subject: device/dram/ddr2: Add break to several case statements that lack it
......................................................................

device/dram/ddr2: Add break to several case statements that lack it

For all valid SPD values the same decoded tRR was returned.

Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65
Signed-off-by: Patrick Georgi <pgeorgi at google.com>
Found-by: Coverity Scan #1381369, #1381370, 1381371, 1381372, 1381373
---
M src/device/dram/ddr2.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/21642/1

diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c
index 6f43563..2dab681 100644
--- a/src/device/dram/ddr2.c
+++ b/src/device/dram/ddr2.c
@@ -194,16 +194,22 @@
 		return CB_ERR;
 	case 0x80:
 		*tRR = 15625 << 8;
+		break;
 	case 0x81:
 		*tRR = 15625 << 6;
+		break;
 	case 0x82:
 		*tRR = 15625 << 7;
+		break;
 	case 0x83:
 		*tRR = 15625 << 9;
+		break;
 	case 0x84:
 		*tRR = 15625 << 10;
+		break;
 	case 0x85:
 		*tRR = 15625 << 11;
+		break;
 	}
 	return CB_SUCCESS;
 }

-- 
To view, visit https://review.coreboot.org/21642
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65
Gerrit-Change-Number: 21642
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170922/e6af0943/attachment.html>