<p>Patrick Georgi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21642">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">device/dram/ddr2: Add break to several case statements that lack it<br><br>For all valid SPD values the same decoded tRR was returned.<br><br>Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65<br>Signed-off-by: Patrick Georgi <pgeorgi@google.com><br>Found-by: Coverity Scan #1381369, #1381370, 1381371, 1381372, 1381373<br>---<br>M src/device/dram/ddr2.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/21642/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c<br>index 6f43563..2dab681 100644<br>--- a/src/device/dram/ddr2.c<br>+++ b/src/device/dram/ddr2.c<br>@@ -194,16 +194,22 @@<br>               return CB_ERR;<br>        case 0x80:<br>            *tRR = 15625 << 8;<br>+             break;<br>        case 0x81:<br>            *tRR = 15625 << 6;<br>+             break;<br>        case 0x82:<br>            *tRR = 15625 << 7;<br>+             break;<br>        case 0x83:<br>            *tRR = 15625 << 9;<br>+             break;<br>        case 0x84:<br>            *tRR = 15625 << 10;<br>+            break;<br>        case 0x85:<br>            *tRR = 15625 << 11;<br>+            break;<br>        }<br>     return CB_SUCCESS;<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/21642">change 21642</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21642"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65 </div>
<div style="display:none"> Gerrit-Change-Number: 21642 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Patrick Georgi <pgeorgi@google.com> </div>