[coreboot-gerrit] Change in coreboot[master]: Makefile: Don't rebuild when generating tags or file list

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/21585 )

Change subject: Makefile: Don't rebuild when generating tags or file list
......................................................................

Makefile: Don't rebuild when generating tags or file list

Generating a project file list used to do a rebuild of the project.
Instead, just make sure there's a coreboot.rom file present and if
it is, generate the list.

Change-Id: I9cc12ef3d1990c3422625630451b2a7b8d77829c
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/21585
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M Makefile
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/Makefile b/Makefile
index 383d583..4ad0177 100644
--- a/Makefile
+++ b/Makefile
@@ -369,13 +369,16 @@
 $(shell mkdir -p $(KCONFIG_SPLITCONFIG) $(objk)/lxdialog $(additional-dirs) $(alldirs))
 endif
 
-$(obj)/project_filelist.txt: all
+$(obj)/project_filelist.txt:
+	if [ -z "$(wildcard $(obj)/coreboot.rom)" ]; then \
+		echo "*** Error: Project must be built before generating file list ***"; \
+		exit 1; \
+	fi
 	find $(obj) -name "*.d" -exec cat {} \; | \
 	  sed 's/[:\\]/ /g' | sed 's/ /\n/g' | sort | uniq | \
 	  grep -v '\.o$$' > $(obj)/project_filelist.txt
 
-filelist: clean
-	$(MAKE) $(obj)/project_filelist.txt
+filelist: $(obj)/project_filelist.txt
 	printf "\nFiles used in build:\n"
 	cat $(obj)/project_filelist.txt
 

-- 
To view, visit https://review.coreboot.org/21585
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cc12ef3d1990c3422625630451b2a7b8d77829c
Gerrit-Change-Number: 21585
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170921/4884b20e/attachment.html>