<p>Martin Roth <strong>merged</strong> this change.</p><p><a href="https://review.coreboot.org/21585">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Makefile: Don't rebuild when generating tags or file list<br><br>Generating a project file list used to do a rebuild of the project.<br>Instead, just make sure there's a coreboot.rom file present and if<br>it is, generate the list.<br><br>Change-Id: I9cc12ef3d1990c3422625630451b2a7b8d77829c<br>Signed-off-by: Martin Roth <martinroth@google.com><br>Reviewed-on: https://review.coreboot.org/21585<br>Tested-by: build bot (Jenkins) <no-reply@coreboot.org><br>Reviewed-by: Patrick Georgi <pgeorgi@google.com><br>---<br>M Makefile<br>1 file changed, 6 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/Makefile b/Makefile<br>index 383d583..4ad0177 100644<br>--- a/Makefile<br>+++ b/Makefile<br>@@ -369,13 +369,16 @@<br> $(shell mkdir -p $(KCONFIG_SPLITCONFIG) $(objk)/lxdialog $(additional-dirs) $(alldirs))<br> endif<br> <br>-$(obj)/project_filelist.txt: all<br>+$(obj)/project_filelist.txt:<br>+       if [ -z "$(wildcard $(obj)/coreboot.rom)" ]; then \<br>+                echo "*** Error: Project must be built before generating file list ***"; \<br>+         exit 1; \<br>+    fi<br>    find $(obj) -name "*.d" -exec cat {} \; | \<br>           sed 's/[:\\]/ /g' | sed 's/ /\n/g' | sort | uniq | \<br>          grep -v '\.o$$' > $(obj)/project_filelist.txt<br> <br>-filelist: clean<br>-      $(MAKE) $(obj)/project_filelist.txt<br>+filelist: $(obj)/project_filelist.txt<br>   printf "\nFiles used in build:\n"<br>   cat $(obj)/project_filelist.txt<br> <br></pre><p>To view, visit <a href="https://review.coreboot.org/21585">change 21585</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21585"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9cc12ef3d1990c3422625630451b2a7b8d77829c </div>
<div style="display:none"> Gerrit-Change-Number: 21585 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>