[coreboot-gerrit] Change in coreboot[master]: Makefile.inc: Add left shift macro

Martin Roth (Code Review) gerrit at coreboot.org
Tue Sep 19 21:46:32 CEST 2017


Martin Roth has posted comments on this change. ( https://review.coreboot.org/21601 )

Change subject: Makefile.inc: Add left shift macro
......................................................................


Patch Set 1:

The other macros aren't using shell inline computation, they're using the expr utility and expr doesn't support exponents.
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/expr.html

bc is posix, so it should already be on everyone's system.
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/bc.html


-- 
To view, visit https://review.coreboot.org/21601
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3fb43b620f31fee2a41f00ddf7294edc81a60f6
Gerrit-Change-Number: 21601
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Sep 2017 19:46:32 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170919/de5f9ccc/attachment.html>


More information about the coreboot-gerrit mailing list