[coreboot-gerrit] Change in coreboot[master]: Makefile.inc: Add left shift macro

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/21601 )

Change subject: Makefile.inc: Add left shift macro
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/21601/1/Makefile.inc
File Makefile.inc:

https://review.coreboot.org/#/c/21601/1/Makefile.inc@138
PS1, Line 138: int-shift-left=$(shell echo "$(call _toint,$(word 1, $1)) * (2 ^ $(call _toint,$(word 2, $1)))" | bc)
Why not just use shell inline computation like the others, e.g.:

  $(shell expr $(call _toint,$(word 1, $1)) << $(call _toint,$(word 2, $1)))

I don't think we have a dependency on bc yet, no reason to add one.



-- 
To view, visit https://review.coreboot.org/21601
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3fb43b620f31fee2a41f00ddf7294edc81a60f6
Gerrit-Change-Number: 21601
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Sep 2017 19:37:52 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170919/7a63c325/attachment.html>