[coreboot-gerrit] Change in coreboot[master]: mainboard/intel/cannonlake_rvp: Set LPSS UART2 to hidden

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/21459 )

Change subject: mainboard/intel/cannonlake_rvp: Set LPSS UART2 to hidden
......................................................................


Patch Set 1:

> (1 comment)

Why we are not setting UPD as PCI mode and take advantage of below code as coreboot already initialize LPSS UART 2 device in PCI mode in bootblock

  case PchSerialIoPci:
      //
      //  Check If device is already initialized
      //
      if (PciSegmentRead32 (PciCfgBase + PCI_BASE_ADDRESSREG_OFFSET) & 0xFFFFF000) {
        return;
      }

Then it has to return rather doing further legacy programming if i use your CL that mean since BB till FSP-S entry we are in 32 bit mode and at exist we are in 8 bit mode again. Because if policy is 
   if (DeviceMode == PchSerialIoHidden) {
      Data32Or = (B_SERIAL_IO_PCR_GPPRVRW7_UART0_BYTE_ADDR_EN << (Controller - PchSerialIoIndexUart0));
    }
then only FSP will set into leagcy 16550 - 8bit mode.

If you still have confusion then raise HSD, i will try to clarify but i don't think this CL make sense


-- 
To view, visit https://review.coreboot.org/21459
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I80619394d8f462a799c57bf0e7589dc34fe67716
Gerrit-Change-Number: 21459
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: clang buildbot
Gerrit-Comment-Date: Sat, 09 Sep 2017 02:02:44 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170909/b6ceb71a/attachment.html>