[coreboot-gerrit] Change in coreboot[master]: mb/intel/dg43gt: Fix smbus IRQ

Arthur Heymans (Code Review) gerrit at coreboot.org
Thu Sep 7 18:19:03 CEST 2017


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/21442


Change subject: mb/intel/dg43gt: Fix smbus IRQ
......................................................................

mb/intel/dg43gt: Fix smbus IRQ

This board uses the reset defaults for DxxIP and DxxIR.
The datasheet "Intel ® I/O Controller Hub 10 (ICH10) Family"
mistakenly says in the D31IP register that all function have INTB as
default. This is however not true as documented in the reset default
value.

This fixes the DSDT such that the SMBus device gets a route for the
INT C interrupt it uses.

Change-Id: I3dd1308fb7acec86b90ecd9d2079cf9a58702c40
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/intel/dg43gt/acpi/x4x_pci_irqs.asl
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/21442/1

diff --git a/src/mainboard/intel/dg43gt/acpi/x4x_pci_irqs.asl b/src/mainboard/intel/dg43gt/acpi/x4x_pci_irqs.asl
index 510af9a..8e56679 100644
--- a/src/mainboard/intel/dg43gt/acpi/x4x_pci_irqs.asl
+++ b/src/mainboard/intel/dg43gt/acpi/x4x_pci_irqs.asl
@@ -52,6 +52,8 @@
 			Package() { 0x001dffff, 3, 0, 0x13 },
 			/* SMBUS/SATA/PATA	0:1f.2, 0:1f.3 */
 			Package() { 0x001fffff, 1, 0, 0x11 },
+			Package() { 0x001fffff, 2, 0, 0x12 },
+			Package() { 0x001fffff, 3, 0, 0x13 },
 		})
 	} Else {
 		Return (Package() {
@@ -86,6 +88,8 @@
 			Package() { 0x001dffff, 3, \_SB.PCI0.LPCB.LNKD, 0 },
 			/* PATA/SATA/SMBUS		0:1f.1-3 */
 			Package() { 0x001fffff, 1, \_SB.PCI0.LPCB.LNKB, 0 },
+			Package() { 0x001fffff, 2, \_SB.PCI0.LPCB.LNKC, 0 },
+			Package() { 0x001fffff, 3, \_SB.PCI0.LPCB.LNKD, 0 },
 		})
 	}
 }

-- 
To view, visit https://review.coreboot.org/21442
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3dd1308fb7acec86b90ecd9d2079cf9a58702c40
Gerrit-Change-Number: 21442
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170907/3c8d50c1/attachment.html>


More information about the coreboot-gerrit mailing list