[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Remove duplicate PCI definitions
Marc Jones (Code Review)
gerrit at coreboot.org
Tue Sep 5 18:33:24 CEST 2017
Marc Jones has posted comments on this change. ( https://review.coreboot.org/21333 )
Change subject: amd/stoneyridge: Remove duplicate PCI definitions
......................................................................
Patch Set 1:
(1 comment)
Where are the other definitions?
https://review.coreboot.org/#/c/21333/1/src/soc/amd/stoneyridge/include/soc/pci_devs.h
File src/soc/amd/stoneyridge/include/soc/pci_devs.h:
https://review.coreboot.org/#/c/21333/1/src/soc/amd/stoneyridge/include/soc/pci_devs.h@a22
PS1, Line 22:
A comment about where these are declared would be helpful here. I'd assume that they needed to be in this file with the others.
--
To view, visit https://review.coreboot.org/21333
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iafb10476f32505f6b4ad7b5ba6fa5de2c4648836
Gerrit-Change-Number: 21333
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 05 Sep 2017 16:33:24 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170905/33883009/attachment.html>
More information about the coreboot-gerrit
mailing list