<p>Marc Jones <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/21333">View Change</a></p><p>Patch set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Where are the other definitions?</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/21333/1/src/soc/amd/stoneyridge/include/soc/pci_devs.h">File src/soc/amd/stoneyridge/include/soc/pci_devs.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/21333/1/src/soc/amd/stoneyridge/include/soc/pci_devs.h@a22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">A comment about where these are declared would be helpful here. I'd assume that they needed to be in this file with the others.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/21333">change 21333</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21333"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iafb10476f32505f6b4ad7b5ba6fa5de2c4648836 </div>
<div style="display:none"> Gerrit-Change-Number: 21333 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Marc Jones <marc@marcjonesconsulting.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 05 Sep 2017 16:33:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>