[coreboot-gerrit] Change in coreboot[master]: cpu/x86/sipi_vector.S: Use correct op suffix

Damien Zammit (Code Review) gerrit at coreboot.org
Sun Sep 3 02:42:01 CEST 2017


Damien Zammit has uploaded this change for review. ( https://review.coreboot.org/21359


Change subject: cpu/x86/sipi_vector.S: Use correct op suffix
......................................................................

cpu/x86/sipi_vector.S: Use correct op suffix

clang wont compile `cmp` asm opcode because it's ambiguous,
use the correct op suffix `cmpl`

Change-Id: I82da5a9065b382e182dc7d502c7dca2fc717543b
Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
M src/cpu/x86/sipi_vector.S
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/21359/1

diff --git a/src/cpu/x86/sipi_vector.S b/src/cpu/x86/sipi_vector.S
index 1abf3f5..b40ea76 100644
--- a/src/cpu/x86/sipi_vector.S
+++ b/src/cpu/x86/sipi_vector.S
@@ -132,7 +132,7 @@
 	jnz	microcode_done
 
 	/* Determine if parallel microcode loading is allowed. */
-	cmp	$0xffffffff, microcode_lock
+	cmpl	$0xffffffff, microcode_lock
 	je	load_microcode
 
 	/* Protect microcode loading. */
@@ -153,7 +153,7 @@
 	popa
 
 	/* Unconditionally unlock microcode loading. */
-	cmp	$0xffffffff, microcode_lock
+	cmpl	$0xffffffff, microcode_lock
 	je	microcode_done
 
 	xor	%eax, %eax

-- 
To view, visit https://review.coreboot.org/21359
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82da5a9065b382e182dc7d502c7dca2fc717543b
Gerrit-Change-Number: 21359
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Zammit <damien at zamaudio.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170903/8a154856/attachment.html>


More information about the coreboot-gerrit mailing list