<p>Damien Zammit has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/21359">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cpu/x86/sipi_vector.S: Use correct op suffix<br><br>clang wont compile `cmp` asm opcode because it's ambiguous,<br>use the correct op suffix `cmpl`<br><br>Change-Id: I82da5a9065b382e182dc7d502c7dca2fc717543b<br>Signed-off-by: Damien Zammit <damien@zamaudio.com><br>---<br>M src/cpu/x86/sipi_vector.S<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/21359/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/cpu/x86/sipi_vector.S b/src/cpu/x86/sipi_vector.S<br>index 1abf3f5..b40ea76 100644<br>--- a/src/cpu/x86/sipi_vector.S<br>+++ b/src/cpu/x86/sipi_vector.S<br>@@ -132,7 +132,7 @@<br>   jnz     microcode_done<br> <br>     /* Determine if parallel microcode loading is allowed. */<br>-    cmp     $0xffffffff, microcode_lock<br>+  cmpl    $0xffffffff, microcode_lock<br>   je      load_microcode<br> <br>     /* Protect microcode loading. */<br>@@ -153,7 +153,7 @@<br>         popa<br> <br>       /* Unconditionally unlock microcode loading. */<br>-      cmp     $0xffffffff, microcode_lock<br>+  cmpl    $0xffffffff, microcode_lock<br>   je      microcode_done<br> <br>     xor     %eax, %eax<br></pre><p>To view, visit <a href="https://review.coreboot.org/21359">change 21359</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/21359"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I82da5a9065b382e182dc7d502c7dca2fc717543b </div>
<div style="display:none"> Gerrit-Change-Number: 21359 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Damien Zammit <damien@zamaudio.com> </div>