[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus:: Enable Dialog DA7219 support

Naveen Manohar (Code Review) gerrit at coreboot.org
Tue Oct 31 19:58:48 CET 2017


Naveen Manohar has uploaded this change for review. ( https://review.coreboot.org/22264


Change subject: mb/google/poppy/variants/nautilus:: Enable Dialog DA7219 support
......................................................................

mb/google/poppy/variants/nautilus:: Enable Dialog DA7219 support

Enable Dialog DA7219 codec i2c device and add required
SSDT parameters.

BUG=b:68686020
TEST=With required driver support in kernel verify audio on headset

Change-Id: Ic815c929f29bec0d26a2981e9933b752c2d84c70
Signed-off-by: Shruthi Sudhakar <shruthi.sudhakar at intel.com>
Signed-off-by: Naveen Manohar <naveen.m at intel.com>
---
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/poppy/variants/nautilus/devicetree.cb
M src/mainboard/google/poppy/variants/nautilus/gpio.c
3 files changed, 28 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/22264/1

diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig
index a6ba1a8..ceaf7eb 100644
--- a/src/mainboard/google/poppy/Kconfig
+++ b/src/mainboard/google/poppy/Kconfig
@@ -3,6 +3,7 @@
 	def_bool n
 	select BOARD_ID_AUTO
 	select BOARD_ROMSIZE_KB_16384
+	select DRIVERS_I2C_DA7219 if BOARD_GOOGLE_NAUTILUS
 	select DRIVERS_I2C_GENERIC
 	select DRIVERS_I2C_HID
 	select DRIVERS_I2C_MAX98927 if !BOARD_GOOGLE_NAUTILUS
diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
index 9530cd9..6618698 100644
--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
@@ -204,6 +204,13 @@
 		[PchSerialIoIndexUart2] = PchSerialIoSkipInit,
 	}"
 
+	# Enable I2C5 for audio codec at 400kHz
+		register "i2c[5]" = "{
+		.speed = I2C_SPEED_FAST,
+		.rise_time_ns = 104,
+		.fall_time_ns = 52,
+	}"
+
 	register "speed_shift_enable" = "1"
 	# PL2 override 15W for KBL-Y
 	register "tdp_pl2_override" = "15"
@@ -241,7 +248,25 @@
 		device pci 16.4 off end # Management Engine Interface 3
 		device pci 17.0 off end # SATA
 		device pci 19.0 on  end # UART #2
-		device pci 19.1 on  end # I2C #5
+		device pci 19.1 on
+			chip drivers/i2c/da7219
+				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)"
+				register "btn_cfg" = "50"
+				register "mic_det_thr" = "500"
+				register "jack_ins_deb" = "20"
+				register "jack_det_rate" = ""32ms_64ms""
+				register "jack_rem_deb" = "1"
+				register "a_d_btn_thr" = "0xa"
+				register "d_b_btn_thr" = "0x16"
+				register "b_c_btn_thr" = "0x21"
+				register "c_mic_btn_thr" = "0x3e"
+				register "btn_avg" = "4"
+				register "adc_1bit_rpt" = "1"
+				register "micbias_lvl" = "2600"
+				register "mic_amp_in_sel" = ""diff""
+				device i2c 1A on end
+			end
+		end # I2C #5
 		device pci 19.2 on  end # I2C #4
 		device pci 1c.0 on
 			chip drivers/intel/wifi
diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c
index 6f7a3e7..bf56395 100644
--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c
+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c
@@ -195,7 +195,7 @@
 	/* D8  : ISH_I2C1_SCL ==> NC */
 	PAD_CFG_NC(GPP_D8),
 	/* D9  : ISH_SPI_CS# ==> HP_IRQ_GPIO */
-	PAD_CFG_GPI(GPP_D9, NONE, PLTRST),
+	PAD_CFG_GPI_APIC(GPP_D9, 20K_PU, DEEP),
 	/* D10 : ISH_SPI_CLK ==> SPKR_RST_L */
 	PAD_CFG_GPO(GPP_D10, 1, DEEP),
 	/* D11 : ISH_SPI_MISO ==> SPKR_INT_L */

-- 
To view, visit https://review.coreboot.org/22264
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic815c929f29bec0d26a2981e9933b752c2d84c70
Gerrit-Change-Number: 22264
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Manohar <naveen.m at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171031/8f768466/attachment-0001.html>


More information about the coreboot-gerrit mailing list