<p>Naveen Manohar has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22264">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy/variants/nautilus:: Enable Dialog DA7219 support<br><br>Enable Dialog DA7219 codec i2c device and add required<br>SSDT parameters.<br><br>BUG=b:68686020<br>TEST=With required driver support in kernel verify audio on headset<br><br>Change-Id: Ic815c929f29bec0d26a2981e9933b752c2d84c70<br>Signed-off-by: Shruthi Sudhakar <shruthi.sudhakar@intel.com><br>Signed-off-by: Naveen Manohar <naveen.m@intel.com><br>---<br>M src/mainboard/google/poppy/Kconfig<br>M src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>M src/mainboard/google/poppy/variants/nautilus/gpio.c<br>3 files changed, 28 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/22264/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig<br>index a6ba1a8..ceaf7eb 100644<br>--- a/src/mainboard/google/poppy/Kconfig<br>+++ b/src/mainboard/google/poppy/Kconfig<br>@@ -3,6 +3,7 @@<br> def_bool n<br> select BOARD_ID_AUTO<br> select BOARD_ROMSIZE_KB_16384<br>+ select DRIVERS_I2C_DA7219 if BOARD_GOOGLE_NAUTILUS<br> select DRIVERS_I2C_GENERIC<br> select DRIVERS_I2C_HID<br> select DRIVERS_I2C_MAX98927 if !BOARD_GOOGLE_NAUTILUS<br>diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>index 9530cd9..6618698 100644<br>--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb<br>@@ -204,6 +204,13 @@<br> [PchSerialIoIndexUart2] = PchSerialIoSkipInit,<br> }"<br> <br>+ # Enable I2C5 for audio codec at 400kHz<br>+ register "i2c[5]" = "{<br>+ .speed = I2C_SPEED_FAST,<br>+ .rise_time_ns = 104,<br>+ .fall_time_ns = 52,<br>+ }"<br>+<br> register "speed_shift_enable" = "1"<br> # PL2 override 15W for KBL-Y<br> register "tdp_pl2_override" = "15"<br>@@ -241,7 +248,25 @@<br> device pci 16.4 off end # Management Engine Interface 3<br> device pci 17.0 off end # SATA<br> device pci 19.0 on end # UART #2<br>- device pci 19.1 on end # I2C #5<br>+ device pci 19.1 on<br>+ chip drivers/i2c/da7219<br>+ register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D9_IRQ)"<br>+ register "btn_cfg" = "50"<br>+ register "mic_det_thr" = "500"<br>+ register "jack_ins_deb" = "20"<br>+ register "jack_det_rate" = ""32ms_64ms""<br>+ register "jack_rem_deb" = "1"<br>+ register "a_d_btn_thr" = "0xa"<br>+ register "d_b_btn_thr" = "0x16"<br>+ register "b_c_btn_thr" = "0x21"<br>+ register "c_mic_btn_thr" = "0x3e"<br>+ register "btn_avg" = "4"<br>+ register "adc_1bit_rpt" = "1"<br>+ register "micbias_lvl" = "2600"<br>+ register "mic_amp_in_sel" = ""diff""<br>+ device i2c 1A on end<br>+ end<br>+ end # I2C #5<br> device pci 19.2 on end # I2C #4<br> device pci 1c.0 on<br> chip drivers/intel/wifi<br>diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c<br>index 6f7a3e7..bf56395 100644<br>--- a/src/mainboard/google/poppy/variants/nautilus/gpio.c<br>+++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c<br>@@ -195,7 +195,7 @@<br> /* D8 : ISH_I2C1_SCL ==> NC */<br> PAD_CFG_NC(GPP_D8),<br> /* D9 : ISH_SPI_CS# ==> HP_IRQ_GPIO */<br>- PAD_CFG_GPI(GPP_D9, NONE, PLTRST),<br>+ PAD_CFG_GPI_APIC(GPP_D9, 20K_PU, DEEP),<br> /* D10 : ISH_SPI_CLK ==> SPKR_RST_L */<br> PAD_CFG_GPO(GPP_D10, 1, DEEP),<br> /* D11 : ISH_SPI_MISO ==> SPKR_INT_L */<br></pre><p>To view, visit <a href="https://review.coreboot.org/22264">change 22264</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22264"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic815c929f29bec0d26a2981e9933b752c2d84c70 </div>
<div style="display:none"> Gerrit-Change-Number: 22264 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Naveen Manohar <naveen.m@intel.com> </div>