[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown

Roy Mingi Park (Code Review) gerrit at coreboot.org
Tue Oct 31 04:42:38 CET 2017


Hello Rajneesh Bhardwaj, Rushikesh S Kadam, build bot (Jenkins), Furquan Shaikh, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22237

to look at the new patch set (#2).

Change subject: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown
......................................................................

soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown

24MHz Crystal Shutdown Qualification bit (0x31Ch[22]) need to be '0'
if system can enter S0ix with XTAL Shutdown.
Note: This patch should be applyied togather with below two patches
so that system can enter S0ix with XTAL Shutdown.
1. https://review.coreboot.org/c/22236
2. https://review.coreboot.org/c/22240

BUG=None
BRANCH=None
TEST=Build for kabylake board with XTAL Disqualification off in pmc.h
And read 24MHz Crystal Shutdown Qualification bit (0x31Ch[22])

iotools mmio_read32 0xFE00031c should return '0' on BIT[22]

Change-Id: I8abc6e9b88b3bc25cf865824aa14b292ac0524ef
Signed-off-by: Roy Mingi Park <roy.mingi.park at intel.com>
---
M src/soc/intel/skylake/include/soc/pmc.h
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/22237/2
-- 
To view, visit https://review.coreboot.org/22237
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8abc6e9b88b3bc25cf865824aa14b292ac0524ef
Gerrit-Change-Number: 22237
Gerrit-PatchSet: 2
Gerrit-Owner: Roy Mingi Park <roy.mingi.park at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj at intel.corp-partner.google.com>
Gerrit-Reviewer: Rushikesh S Kadam <rushikesh.s.kadam at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171031/42e240cc/attachment.html>


More information about the coreboot-gerrit mailing list