[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown

rushikesh s kadam (Code Review) gerrit at coreboot.org
Tue Oct 31 04:20:13 CET 2017


rushikesh s kadam has posted comments on this change. ( https://review.coreboot.org/22237 )

Change subject: soc/intel/skylake: Turnoff XTAL Disqualification for XTAL Shutdown
......................................................................


Patch Set 1:

Roy, 
If we turn off XTAL disqualification, the SoC will not enter S0ix for scenarios such as Wake-On-Voice. 

We could enable / disable in ASL based on WoV status, or we could just leave it on. 

Btw I did not see you reset the bit in this patch?


-- 
To view, visit https://review.coreboot.org/22237
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8abc6e9b88b3bc25cf865824aa14b292ac0524ef
Gerrit-Change-Number: 22237
Gerrit-PatchSet: 1
Gerrit-Owner: Roy Mingi Park <roy.mingi.park at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Rajneesh Bhardwaj <rajneesh.bhardwaj at intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: rushikesh s kadam <rushikesh.s.kadam at intel.com>
Gerrit-Comment-Date: Tue, 31 Oct 2017 03:20:13 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171031/88814d10/attachment.html>


More information about the coreboot-gerrit mailing list