[coreboot-gerrit] Change in coreboot[master]: spi/tpm: Make sure AP properly syncs up with Cr50

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22231 )

Change subject: spi/tpm: Make sure AP properly syncs up with Cr50
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22231/1/src/drivers/spi/tpm/tpm.c
File src/drivers/spi/tpm/tpm.c:

https://review.coreboot.org/#/c/22231/1/src/drivers/spi/tpm/tpm.c@394
PS1, Line 394: 		tpm2_read_reg(TPM_DID_VID_REG, &did_vid, sizeof(did_vid));
> Could you change this to read a different register first (e.g. TPM_STS) so 
I agree



-- 
To view, visit https://review.coreboot.org/22231
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e67ec62c2bf31077b9ae558e09214d07eccf96b
Gerrit-Change-Number: 22231
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Bendebury <vbendeb at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Shelley Chen <shchen at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 30 Oct 2017 19:49:05 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171030/ca2aff10/attachment.html>