<p>Philipp Deppenwiese <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22231">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22231/1/src/drivers/spi/tpm/tpm.c">File src/drivers/spi/tpm/tpm.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22231/1/src/drivers/spi/tpm/tpm.c@394">Patch Set #1, Line 394:</a> <code style="font-family:monospace,monospace">             tpm2_read_reg(TPM_DID_VID_REG, &did_vid, sizeof(did_vid));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Could you change this to read a different register first (e.g. TPM_STS) so </blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22231">change 22231</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22231"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7e67ec62c2bf31077b9ae558e09214d07eccf96b </div>
<div style="display:none"> Gerrit-Change-Number: 22231 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Bendebury <vbendeb@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> </div>
<div style="display:none"> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Shelley Chen <shchen@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 30 Oct 2017 19:49:05 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>