[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Make a weak call for platform PCIE slot reset

Marc Jones (Code Review) gerrit at coreboot.org
Fri Oct 27 00:56:20 CEST 2017


Marc Jones has uploaded this change for review. ( https://review.coreboot.org/22193


Change subject: soc/amd/common: Make a weak call for platform PCIE slot reset
......................................................................

soc/amd/common: Make a weak call for platform PCIE slot reset

Since it is fairly uncommon, add a weak call that may be done by
the platform if it has the support.

BUG=b:66690176
BRANCH=none
TEST=coreboot builds.

Change-Id: I50008da6f85039a428184bf9e7642c0aa6610247
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/soc/amd/common/BiosCallOuts.h
M src/soc/amd/common/def_callouts.c
2 files changed, 10 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/22193/1

diff --git a/src/soc/amd/common/BiosCallOuts.h b/src/soc/amd/common/BiosCallOuts.h
index 1f1ebf7..4397e4b 100644
--- a/src/soc/amd/common/BiosCallOuts.h
+++ b/src/soc/amd/common/BiosCallOuts.h
@@ -64,6 +64,8 @@
 void platform_FchParams_reset(FCH_RESET_DATA_BLOCK *FchParams_reset);
 void platform_FchParams_env(FCH_DATA_BLOCK *FchParams_env);
 void oem_fan_control(FCH_DATA_BLOCK *FchParams);
+void platform_PcieSlotResetControl(UINT32 Func, UINTN Data,
+	VOID *ConfigPtr);
 typedef struct {
 	UINT32 CalloutName;
 	CALLOUT_ENTRY CalloutPtr;
diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c
index fd3b5e9..7a6afeb 100644
--- a/src/soc/amd/common/def_callouts.c
+++ b/src/soc/amd/common/def_callouts.c
@@ -162,13 +162,17 @@
 	return Status;
 }
 
+void __attribute__((weak)) platform_PcieSlotResetControl(UINT32 Func, UINTN Data,
+	VOID *ConfigPtr)
+{
+	printk(BIOS_WARNING, "Warning - AGESA callout: %s not supported\n", __func__);
+	return AGESA_UNSUPPORTED;
+}
+
 AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data,
 	VOID *ConfigPtr)
 {
-	printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
-	AGESA_STATUS Status = AGESA_UNSUPPORTED;
-
-	return Status;
+	platform_PcieSlotResetControl(Func, Data, ConfigPtr)
 }
 
 AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data,

-- 
To view, visit https://review.coreboot.org/22193
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50008da6f85039a428184bf9e7642c0aa6610247
Gerrit-Change-Number: 22193
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171026/29299229/attachment.html>


More information about the coreboot-gerrit mailing list