<p>Marc Jones has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22193">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/common: Make a weak call for platform PCIE slot reset<br><br>Since it is fairly uncommon, add a weak call that may be done by<br>the platform if it has the support.<br><br>BUG=b:66690176<br>BRANCH=none<br>TEST=coreboot builds.<br><br>Change-Id: I50008da6f85039a428184bf9e7642c0aa6610247<br>Signed-off-by: Marc Jones <marcj303@gmail.com><br>---<br>M src/soc/amd/common/BiosCallOuts.h<br>M src/soc/amd/common/def_callouts.c<br>2 files changed, 10 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/22193/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/soc/amd/common/BiosCallOuts.h b/src/soc/amd/common/BiosCallOuts.h<br>index 1f1ebf7..4397e4b 100644<br>--- a/src/soc/amd/common/BiosCallOuts.h<br>+++ b/src/soc/amd/common/BiosCallOuts.h<br>@@ -64,6 +64,8 @@<br> void platform_FchParams_reset(FCH_RESET_DATA_BLOCK *FchParams_reset);<br> void platform_FchParams_env(FCH_DATA_BLOCK *FchParams_env);<br> void oem_fan_control(FCH_DATA_BLOCK *FchParams);<br>+void platform_PcieSlotResetControl(UINT32 Func, UINTN Data,<br>+  VOID *ConfigPtr);<br> typedef struct {<br>  UINT32 CalloutName;<br>   CALLOUT_ENTRY CalloutPtr;<br>diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c<br>index fd3b5e9..7a6afeb 100644<br>--- a/src/soc/amd/common/def_callouts.c<br>+++ b/src/soc/amd/common/def_callouts.c<br>@@ -162,13 +162,17 @@<br>         return Status;<br> }<br> <br>+void __attribute__((weak)) platform_PcieSlotResetControl(UINT32 Func, UINTN Data,<br>+    VOID *ConfigPtr)<br>+{<br>+ printk(BIOS_WARNING, "Warning - AGESA callout: %s not supported\n", __func__);<br>+     return AGESA_UNSUPPORTED;<br>+}<br>+<br> AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data,<br>   VOID *ConfigPtr)<br> {<br>- printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);<br>-   AGESA_STATUS Status = AGESA_UNSUPPORTED;<br>-<br>-  return Status;<br>+       platform_PcieSlotResetControl(Func, Data, ConfigPtr)<br> }<br> <br> AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data,<br></pre><p>To view, visit <a href="https://review.coreboot.org/22193">change 22193</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22193"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I50008da6f85039a428184bf9e7642c0aa6610247 </div>
<div style="display:none"> Gerrit-Change-Number: 22193 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Marc Jones <marc@marcjonesconsulting.com> </div>