[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Set coreboot ready LED

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/22136 )

Change subject: siemens/mc_apl1: Set coreboot ready LED
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/22136/1/src/mainboard/siemens/mc_apl1/mainboard.c
File src/mainboard/siemens/mc_apl1/mainboard.c:

https://review.coreboot.org/#/c/22136/1/src/mainboard/siemens/mc_apl1/mainboard.c@177
PS1, Line 177: printk(BIOS_INFO, "MC_APL1: coreboot is now finished.\n");
Do we really need this info in the console? If yes, then set the level upo to BIOS_DEBUG and modify the text like:
"MC_APL1: coreboot is finished now.\n"


https://review.coreboot.org/#/c/22136/1/src/mainboard/siemens/mc_apl1/mainboard.c@180
PS1, Line 180: 
Skip this additional empty line.



-- 
To view, visit https://review.coreboot.org/22136
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I179d013746c1334337dc9e6b7f09ac54eff0cd77
Gerrit-Change-Number: 22136
Gerrit-PatchSet: 1
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 25 Oct 2017 10:40:17 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171025/96770ce0/attachment.html>