<p>Werner Zeh <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22136">View Change</a></p><p>Patch set 1:</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22136/1/src/mainboard/siemens/mc_apl1/mainboard.c">File src/mainboard/siemens/mc_apl1/mainboard.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22136/1/src/mainboard/siemens/mc_apl1/mainboard.c@177">Patch Set #1, Line 177:</a> <code style="font-family:monospace,monospace">printk(BIOS_INFO, "MC_APL1: coreboot is now finished.\n");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we really need this info in the console? If yes, then set the level upo to BIOS_DEBUG and modify the text like:<br>"MC_APL1: coreboot is finished now.\n"</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22136/1/src/mainboard/siemens/mc_apl1/mainboard.c@180">Patch Set #1, Line 180:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Skip this additional empty line.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22136">change 22136</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22136"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I179d013746c1334337dc9e6b7f09ac54eff0cd77 </div>
<div style="display:none"> Gerrit-Change-Number: 22136 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Mario Scheithauer <mario.scheithauer@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 25 Oct 2017 10:40:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>