[coreboot-gerrit] Change in coreboot[master]: superio/ite/common: Remove PECI sanity check

[Vagiz Tarkhanov (Code Review)]

Vagiz Tarkhanov has uploaded this change for review. ( https://review.coreboot.org/22142


Change subject: superio/ite/common: Remove PECI sanity check
......................................................................

superio/ite/common: Remove PECI sanity check

This check causes a bug. PECI readings would freeze after system reboot
until next suspend/resume; in coreboot console one can find the message
from the sanity check.

My guess is that ITE_EC_ADC_TEMP_CHANNEL_ENABLE isn't cleared during
reboots, so even with one THERMAL_PECI this sanity checks gets triggered,
which stops further PECI enablement. On the other hand, a suspend/resume
cycle clears ITE_EC_ADC_TEMP_CHANNEL_ENABLE therefore PECI enablement
succeeds.

Also, the sanity check isn't that important since the enablement
procedure will simply overwrite previous values if there are any. Should
somebody sets several THERMAL_PECI in their devicetree, only the last
one will be active. No problem.

Change-Id: I81bfd4e5eec7f28e0a86773512ead55bf988d5d5
Signed-off-by: Vagiz Trakhanov <rakkin at autistici.org>
---
M src/superio/ite/common/env_ctrl.c
1 file changed, 0 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/22142/1

diff --git a/src/superio/ite/common/env_ctrl.c b/src/superio/ite/common/env_ctrl.c
index b78d250..8c9c137 100644
--- a/src/superio/ite/common/env_ctrl.c
+++ b/src/superio/ite/common/env_ctrl.c
@@ -100,10 +100,6 @@
 
 	switch (conf->mode) {
 	case THERMAL_PECI:
-		if (reg & ITE_EC_ADC_TEMP_EXT_REPORTS_TO_MASK) {
-			printk(BIOS_WARNING, "PECI specified for multiple TMPIN\n");
-			return;
-		}
 		enable_peci(base);
 		reg |= ITE_EC_ADC_TEMP_EXT_REPORTS_TO(tmpin);
 		break;

-- 
To view, visit https://review.coreboot.org/22142
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81bfd4e5eec7f28e0a86773512ead55bf988d5d5
Gerrit-Change-Number: 22142
Gerrit-PatchSet: 1
Gerrit-Owner: Vagiz Tarkhanov <rakkin at autistici.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171023/5bcdcc2e/attachment.html>