<p>Vagiz Tarkhanov has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22142">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">superio/ite/common: Remove PECI sanity check<br><br>This check causes a bug. PECI readings would freeze after system reboot<br>until next suspend/resume; in coreboot console one can find the message<br>from the sanity check.<br><br>My guess is that ITE_EC_ADC_TEMP_CHANNEL_ENABLE isn't cleared during<br>reboots, so even with one THERMAL_PECI this sanity checks gets triggered,<br>which stops further PECI enablement. On the other hand, a suspend/resume<br>cycle clears ITE_EC_ADC_TEMP_CHANNEL_ENABLE therefore PECI enablement<br>succeeds.<br><br>Also, the sanity check isn't that important since the enablement<br>procedure will simply overwrite previous values if there are any. Should<br>somebody sets several THERMAL_PECI in their devicetree, only the last<br>one will be active. No problem.<br><br>Change-Id: I81bfd4e5eec7f28e0a86773512ead55bf988d5d5<br>Signed-off-by: Vagiz Trakhanov <rakkin@autistici.org><br>---<br>M src/superio/ite/common/env_ctrl.c<br>1 file changed, 0 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/22142/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/superio/ite/common/env_ctrl.c b/src/superio/ite/common/env_ctrl.c<br>index b78d250..8c9c137 100644<br>--- a/src/superio/ite/common/env_ctrl.c<br>+++ b/src/superio/ite/common/env_ctrl.c<br>@@ -100,10 +100,6 @@<br> <br>      switch (conf->mode) {<br>      case THERMAL_PECI:<br>-           if (reg & ITE_EC_ADC_TEMP_EXT_REPORTS_TO_MASK) {<br>-                 printk(BIOS_WARNING, "PECI specified for multiple TMPIN\n");<br>-                       return;<br>-              }<br>             enable_peci(base);<br>            reg |= ITE_EC_ADC_TEMP_EXT_REPORTS_TO(tmpin);<br>                 break;<br></pre><p>To view, visit <a href="https://review.coreboot.org/22142">change 22142</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22142"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I81bfd4e5eec7f28e0a86773512ead55bf988d5d5 </div>
<div style="display:none"> Gerrit-Change-Number: 22142 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vagiz Tarkhanov <rakkin@autistici.org> </div>