[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add platform.asl
Lijian Zhao (Code Review)
gerrit at coreboot.org
Thu Oct 19 21:15:15 CEST 2017
Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/22111
Change subject: soc/intel/cannonlake: Add platform.asl
......................................................................
soc/intel/cannonlake: Add platform.asl
Include common platform.asl to have generic indication of power
transition state of system.
TEST=Enter and resume from S3, check the post code had been changed to
0096 and 0097.
Change-Id: Ic38ac6d7e60441caeba5c088c9dbe4d901355782
Signed-off-by: Lijian Zhao <lijian.zhao at intel.com>
---
M src/mainboard/intel/cannonlake_rvp/dsdt.asl
M src/soc/intel/cannonlake/acpi/platform.asl
2 files changed, 5 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/22111/1
diff --git a/src/mainboard/intel/cannonlake_rvp/dsdt.asl b/src/mainboard/intel/cannonlake_rvp/dsdt.asl
index 46d41e1..5c4b31c 100644
--- a/src/mainboard/intel/cannonlake_rvp/dsdt.asl
+++ b/src/mainboard/intel/cannonlake_rvp/dsdt.asl
@@ -24,6 +24,9 @@
0x20110725 // OEM revision
)
{
+ // Some generic macros
+ #include <soc/intel/cannonlake/acpi/platform.asl>
+
// global NVS and variables
#include <soc/intel/cannonlake/acpi/globalnvs.asl>
diff --git a/src/soc/intel/cannonlake/acpi/platform.asl b/src/soc/intel/cannonlake/acpi/platform.asl
index 17a19d9..773cdcb 100644
--- a/src/soc/intel/cannonlake/acpi/platform.asl
+++ b/src/soc/intel/cannonlake/acpi/platform.asl
@@ -17,6 +17,8 @@
/* Enable ACPI _SWS methods */
#include <soc/intel/common/acpi/acpi_wake_source.asl>
+/* Generic indicator for sleep state */
+#include <soc/intel/common/acpi/platform.asl>
/* The APM port can be used for generating software SMIs */
@@ -25,14 +27,6 @@
{
APMC, 8, // APM command
APMS, 8 // APM status
-}
-
-/* Port 80 POST */
-
-OperationRegion (POST, SystemIO, 0x80, 1)
-Field (POST, ByteAcc, Lock, Preserve)
-{
- DBG0, 8
}
/*
@@ -47,20 +41,4 @@
{
/* Remember the OS' IRQ routing choice. */
Store (Arg0, PICM)
-}
-
-/*
- * The _PTS method (Prepare To Sleep) is called before the OS is
- * entering a sleep state. The sleep state number is passed in Arg0
- */
-
-Method (_PTS, 1)
-{
-}
-
-/* The _WAK method is called on system wakeup */
-
-Method (_WAK, 1)
-{
- Return (Package (){ 0, 0 })
}
--
To view, visit https://review.coreboot.org/22111
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic38ac6d7e60441caeba5c088c9dbe4d901355782
Gerrit-Change-Number: 22111
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171019/a08e9e51/attachment.html>
More information about the coreboot-gerrit
mailing list