<p>Lijian Zhao has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22111">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/cannonlake: Add platform.asl<br><br>Include common platform.asl to have generic indication of power<br>transition state of system.<br><br>TEST=Enter and resume from S3, check the post code had been changed to<br>0096 and 0097.<br><br>Change-Id: Ic38ac6d7e60441caeba5c088c9dbe4d901355782<br>Signed-off-by: Lijian Zhao <lijian.zhao@intel.com><br>---<br>M src/mainboard/intel/cannonlake_rvp/dsdt.asl<br>M src/soc/intel/cannonlake/acpi/platform.asl<br>2 files changed, 5 insertions(+), 24 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/22111/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/mainboard/intel/cannonlake_rvp/dsdt.asl b/src/mainboard/intel/cannonlake_rvp/dsdt.asl<br>index 46d41e1..5c4b31c 100644<br>--- a/src/mainboard/intel/cannonlake_rvp/dsdt.asl<br>+++ b/src/mainboard/intel/cannonlake_rvp/dsdt.asl<br>@@ -24,6 +24,9 @@<br>      0x20110725      // OEM revision<br> )<br> {<br>+      // Some generic macros<br>+       #include <soc/intel/cannonlake/acpi/platform.asl><br>+<br>    // global NVS and variables<br>   #include <soc/intel/cannonlake/acpi/globalnvs.asl><br> <br>diff --git a/src/soc/intel/cannonlake/acpi/platform.asl b/src/soc/intel/cannonlake/acpi/platform.asl<br>index 17a19d9..773cdcb 100644<br>--- a/src/soc/intel/cannonlake/acpi/platform.asl<br>+++ b/src/soc/intel/cannonlake/acpi/platform.asl<br>@@ -17,6 +17,8 @@<br> <br> /* Enable ACPI _SWS methods */<br> #include <soc/intel/common/acpi/acpi_wake_source.asl><br>+/* Generic indicator for sleep state */<br>+#include <soc/intel/common/acpi/platform.asl><br> <br> /* The APM port can be used for generating software SMIs */<br> <br>@@ -25,14 +27,6 @@<br> {<br>         APMC, 8,        // APM command<br>        APMS, 8         // APM status<br>-}<br>-<br>-/* Port 80 POST */<br>-<br>-OperationRegion (POST, SystemIO, 0x80, 1)<br>-Field (POST, ByteAcc, Lock, Preserve)<br>-{<br>- DBG0, 8<br> }<br> <br> /*<br>@@ -47,20 +41,4 @@<br> {<br>   /* Remember the OS' IRQ routing choice. */<br>        Store (Arg0, PICM)<br>-}<br>-<br>-/*<br>- * The _PTS method (Prepare To Sleep) is called before the OS is<br>- * entering a sleep state. The sleep state number is passed in Arg0<br>- */<br>-<br>-Method (_PTS, 1)<br>-{<br>-}<br>-<br>-/* The _WAK method is called on system wakeup */<br>-<br>-Method (_WAK, 1)<br>-{<br>-  Return (Package (){ 0, 0 })<br> }<br></pre><p>To view, visit <a href="https://review.coreboot.org/22111">change 22111</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22111"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic38ac6d7e60441caeba5c088c9dbe4d901355782 </div>
<div style="display:none"> Gerrit-Change-Number: 22111 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> </div>