[coreboot-gerrit] Change in coreboot[master]: superio/acpi/pnp.asl: Fix PNP_READ_DMA macro
Keith Hui (Code Review)
gerrit at coreboot.org
Tue Oct 17 04:38:48 CEST 2017
Keith Hui has uploaded this change for review. ( https://review.coreboot.org/22066
Change subject: superio/acpi/pnp.asl: Fix PNP_READ_DMA macro
......................................................................
superio/acpi/pnp.asl: Fix PNP_READ_DMA macro
This macro, broken since day one, should CreateByteField instead
of CreateWordField. Without the fix, any ASLs that try to use it
will fail to compile with a "ResourceTag smaller than Field"
warning.
Change-Id: Ieeb509aece8836785998b23fdc805a747d40a77a
Signed-off-by: Keith Hui <buurin at gmail.com>
---
M src/superio/acpi/pnp.asl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/22066/1
diff --git a/src/superio/acpi/pnp.asl b/src/superio/acpi/pnp.asl
index 114dfe9..5db5207 100644
--- a/src/superio/acpi/pnp.asl
+++ b/src/superio/acpi/pnp.asl
@@ -124,7 +124,7 @@
ShiftLeft (One, IRQ_FROM, IRQ_TAG##W)
#define PNP_READ_DMA(DMA_FROM, RESOURCE_TEMPLATE, DMA_TAG) \
- CreateWordField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\
+ CreateByteField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\
ShiftLeft (One, DMA_FROM, DMA_TAG##W)
#define PNP_WRITE_IO(IO_TO, RESOURCE, IO_TAG) \
--
To view, visit https://review.coreboot.org/22066
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeb509aece8836785998b23fdc805a747d40a77a
Gerrit-Change-Number: 22066
Gerrit-PatchSet: 1
Gerrit-Owner: Keith Hui <buurin at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171017/791403fe/attachment-0001.html>
More information about the coreboot-gerrit
mailing list