<p>Keith Hui has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22066">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">superio/acpi/pnp.asl: Fix PNP_READ_DMA macro<br><br>This macro, broken since day one, should CreateByteField instead<br>of CreateWordField. Without the fix, any ASLs that try to use it<br>will fail to compile with a "ResourceTag smaller than Field"<br>warning.<br><br>Change-Id: Ieeb509aece8836785998b23fdc805a747d40a77a<br>Signed-off-by: Keith Hui <buurin@gmail.com><br>---<br>M src/superio/acpi/pnp.asl<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/22066/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/superio/acpi/pnp.asl b/src/superio/acpi/pnp.asl<br>index 114dfe9..5db5207 100644<br>--- a/src/superio/acpi/pnp.asl<br>+++ b/src/superio/acpi/pnp.asl<br>@@ -124,7 +124,7 @@<br>  ShiftLeft (One, IRQ_FROM, IRQ_TAG##W)<br> <br> #define PNP_READ_DMA(DMA_FROM, RESOURCE_TEMPLATE, DMA_TAG) \<br>-      CreateWordField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\<br>+       CreateByteField (RESOURCE_TEMPLATE, DMA_TAG._DMA, DMA_TAG##W)\<br>        ShiftLeft (One, DMA_FROM, DMA_TAG##W)<br> <br> #define PNP_WRITE_IO(IO_TO, RESOURCE, IO_TAG) \<br></pre><p>To view, visit <a href="https://review.coreboot.org/22066">change 22066</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22066"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ieeb509aece8836785998b23fdc805a747d40a77a </div>
<div style="display:none"> Gerrit-Change-Number: 22066 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Keith Hui <buurin@gmail.com> </div>