[coreboot-gerrit] Change in coreboot[master]: (WIP) soc/amd/common: Add FV access to SPI

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22065 )

Change subject: (WIP) soc/amd/common: Add FV access to SPI
......................................................................


Patch Set 1:

(2 comments)

This seems like platform independent code.  Could it go into src/drivers/spi instead in the AMD specific code?

https://review.coreboot.org/#/c/22065/1/src/soc/amd/common/block/include/amdblocks/spi.h
File src/soc/amd/common/block/include/amdblocks/spi.h:

https://review.coreboot.org/#/c/22065/1/src/soc/amd/common/block/include/amdblocks/spi.h@52
PS1, Line 52: #if IS_ENABLED(CONFIG_SOUTHBRIDGE_AMD_AGESA_YANGTZE)
            : #define AMD_SB_SPI_TX_LEN	64
            : #else
Unrelated to this patch, but this can be removed as it's not in the SOC.


https://review.coreboot.org/#/c/22065/1/src/soc/amd/common/block/include/amdblocks/spi.h@61
PS1, Line 61: /*
            : + * EFI_FVB_ATTRIBUTES_2
            : + * From UEFI PI spec rev. 1.6
Can all of this go in some other header for just the EFI stuff under include/device?  Is there a reason that this is specific to AMD?



-- 
To view, visit https://review.coreboot.org/22065
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32208a214a6896308833ff34d459d5513b60ba7a
Gerrit-Change-Number: 22065
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: frank vibrans <frank.vibrans at scarletltd.com>
Gerrit-Comment-Date: Tue, 17 Oct 2017 02:26:43 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171017/73130c07/attachment.html>