<p>Martin Roth <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22065">View Change</a></p><p>Patch set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">This seems like platform independent code.  Could it go into src/drivers/spi instead in the AMD specific code?</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22065/1/src/soc/amd/common/block/include/amdblocks/spi.h">File src/soc/amd/common/block/include/amdblocks/spi.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22065/1/src/soc/amd/common/block/include/amdblocks/spi.h@52">Patch Set #1, Line 52:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#if IS_ENABLED(CONFIG_SOUTHBRIDGE_AMD_AGESA_YANGTZE)<br>#define AMD_SB_SPI_TX_LEN    64<br>#else<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Unrelated to this patch, but this can be removed as it's not in the SOC.</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22065/1/src/soc/amd/common/block/include/amdblocks/spi.h@61">Patch Set #1, Line 61:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">/*<br>+ * EFI_FVB_ATTRIBUTES_2<br>+ * From UEFI PI spec rev. 1.6<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Can all of this go in some other header for just the EFI stuff under include/device?  Is there a reason that this is specific to AMD?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22065">change 22065</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22065"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I32208a214a6896308833ff34d459d5513b60ba7a </div>
<div style="display:none"> Gerrit-Change-Number: 22065 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John E. Kabat Jr. <john.kabat@scarletltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: frank vibrans <frank.vibrans@scarletltd.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 17 Oct 2017 02:26:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>