[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Relocate spi.c

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/22062 )

Change subject: soc/amd/common: Relocate spi.c
......................................................................


Patch Set 1:

(5 comments)

https://review.coreboot.org/#/c/22062/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22062/1//COMMIT_MSG@9
PS1, Line 9: elocate spi.c from soc/amd/common to soc/amd/common/block/spi.
Why?


https://review.coreboot.org/#/c/22062/1//COMMIT_MSG@10
PS1, Line 10: make files
one word - makefiles.


https://review.coreboot.org/#/c/22062/1/src/soc/amd/common/block/include/amdblocks/spi.h
File src/soc/amd/common/block/include/amdblocks/spi.h:

https://review.coreboot.org/#/c/22062/1/src/soc/amd/common/block/include/amdblocks/spi.h@15
PS1, Line 15: 
This file seems to be all new, which doesn't align with the commit message.


https://review.coreboot.org/#/c/22062/1/src/soc/amd/common/block/spi/spi.c
File src/soc/amd/common/block/spi/spi.c:

https://review.coreboot.org/#/c/22062/1/src/soc/amd/common/block/spi/spi.c@15
PS1, Line 15: 
A lot seems to have been added here - this doesn't seem to be a simple relocation change set.


https://review.coreboot.org/#/c/22062/1/src/soc/amd/stoneyridge/Kconfig
File src/soc/amd/stoneyridge/Kconfig:

https://review.coreboot.org/#/c/22062/1/src/soc/amd/stoneyridge/Kconfig@59
PS1, Line 59: select SPI_FLASH
Again this has nothing to do with relocating files.



-- 
To view, visit https://review.coreboot.org/22062
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24085fd6ec1d5fedb7269d935fd95a46f00ae687
Gerrit-Change-Number: 22062
Gerrit-PatchSet: 1
Gerrit-Owner: John E. Kabat Jr. <john.kabat at scarletltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Reviewer: frank vibrans <frank.vibrans at scarletltd.com>
Gerrit-Comment-Date: Tue, 17 Oct 2017 02:18:14 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171017/a09601ad/attachment.html>