<p>Martin Roth <strong>posted comments</strong> on this change.</p><p><a href="https://review.coreboot.org/22062">View Change</a></p><p>Patch set 1:</p><p>(5 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://review.coreboot.org/#/c/22062/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22062/1//COMMIT_MSG@9">Patch Set #1, Line 9:</a> <code style="font-family:monospace,monospace">elocate spi.c from soc/amd/common to soc/amd/common/block/spi.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why?</p></li><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22062/1//COMMIT_MSG@10">Patch Set #1, Line 10:</a> <code style="font-family:monospace,monospace">make files</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">one word - makefiles.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/22062/1/src/soc/amd/common/block/include/amdblocks/spi.h">File src/soc/amd/common/block/include/amdblocks/spi.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22062/1/src/soc/amd/common/block/include/amdblocks/spi.h@15">Patch Set #1, Line 15:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This file seems to be all new, which doesn't align with the commit message.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/22062/1/src/soc/amd/common/block/spi/spi.c">File src/soc/amd/common/block/spi/spi.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22062/1/src/soc/amd/common/block/spi/spi.c@15">Patch Set #1, Line 15:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">A lot seems to have been added here - this doesn't seem to be a simple relocation change set.</p></li></ul></li><li><p><a href="https://review.coreboot.org/#/c/22062/1/src/soc/amd/stoneyridge/Kconfig">File src/soc/amd/stoneyridge/Kconfig:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/22062/1/src/soc/amd/stoneyridge/Kconfig@59">Patch Set #1, Line 59:</a> <code style="font-family:monospace,monospace">select SPI_FLASH</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Again this has nothing to do with relocating files.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/22062">change 22062</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22062"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I24085fd6ec1d5fedb7269d935fd95a46f00ae687 </div>
<div style="display:none"> Gerrit-Change-Number: 22062 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: John E. Kabat Jr. <john.kabat@scarletltd.com> </div>
<div style="display:none"> Gerrit-Reviewer: Martin Roth <martinroth@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Reviewer: frank vibrans <frank.vibrans@scarletltd.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 17 Oct 2017 02:18:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>