[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: pass SataSpeedLimit param to FSP2

[Youness Alaoui (Code Review)]

Hello Matt DeVillier,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/22045

to review the following change.


Change subject: soc/intel/skylake: pass SataSpeedLimit param to FSP2
......................................................................

soc/intel/skylake: pass SataSpeedLimit param to FSP2

The Librem13v2 needs to set this parameter to work around
power-related issues with some SATA devices.

Change-Id: I7fcef36ec8662e18834394b72427a0633c6b7e92
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
M src/soc/intel/skylake/chip.h
M src/soc/intel/skylake/chip_fsp20.c
2 files changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/22045/1

diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h
index 022306c..2c282bc 100644
--- a/src/soc/intel/skylake/chip.h
+++ b/src/soc/intel/skylake/chip.h
@@ -148,6 +148,7 @@
 	u8 SataSalpSupport;
 	u8 SataPortsEnable[8];
 	u8 SataPortsDevSlp[8];
+	u8 SataSpeedLimit;
 
 	/* Audio related */
 	u8 EnableAzalia;
diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c
index f9bdf8a..bc0f5a5 100644
--- a/src/soc/intel/skylake/chip_fsp20.c
+++ b/src/soc/intel/skylake/chip_fsp20.c
@@ -206,6 +206,8 @@
 	params->Device4Enable = config->Device4Enable;
 	params->SataEnable = config->EnableSata;
 	params->SataMode = config->SataMode;
+	params->SataSpeedLimit = config->SataSpeedLimit;
+
 	tconfig->PchLockDownGlobalSmi = config->LockDownConfigGlobalSmi;
 	tconfig->PchLockDownRtcLock = config->LockDownConfigRtcLock;
 	/*

-- 
To view, visit https://review.coreboot.org/22045
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fcef36ec8662e18834394b72427a0633c6b7e92
Gerrit-Change-Number: 22045
Gerrit-PatchSet: 1
Gerrit-Owner: Youness Alaoui <snifikino at gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171016/030315ce/attachment-0001.html>