[coreboot-gerrit] Change in coreboot[master]: google/chromeec: Do not set wake mask before logging EC events

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22006


Change subject: google/chromeec: Do not set wake mask before logging EC events
......................................................................

google/chromeec: Do not set wake mask before logging EC events

Earlier the EC expected the host to set appropriate masks before
reading host events. However, with recent change in EC to report all
set host events, setting of wake masks just to query the events is no
longer required. This change removes the setting of wake_mask before
and after reading the host events.

TEST=Verified that EC wake events are correctly logged.

Change-Id: Ib17e1296fb7d3bbc84fc7581fd0a9bd179ac87b9
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/ec/google/chromeec/ec.c
1 file changed, 0 insertions(+), 7 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/22006/1

diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index 639719a..1683a9c 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -245,21 +245,14 @@
 static void google_chromeec_log_events(u32 mask)
 {
 	u8 event;
-	u32 wake_mask;
 
 	if (!IS_ENABLED(CONFIG_ELOG))
 		return;
-
-	/* Set wake mask so events will be read from ACPI interface */
-	wake_mask = google_chromeec_get_wake_mask();
-	google_chromeec_set_wake_mask(mask);
 
 	while ((event = google_chromeec_get_event()) != 0) {
 		if (EC_HOST_EVENT_MASK(event) & mask)
 			elog_add_event_byte(ELOG_TYPE_EC_EVENT, event);
 	}
-
-	google_chromeec_set_wake_mask(wake_mask);
 }
 
 void google_chromeec_events_init(const struct google_chromeec_event_info *info,

-- 
To view, visit https://review.coreboot.org/22006
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib17e1296fb7d3bbc84fc7581fd0a9bd179ac87b9
Gerrit-Change-Number: 22006
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171013/633bba8f/attachment.html>