<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/22006">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">google/chromeec: Do not set wake mask before logging EC events<br><br>Earlier the EC expected the host to set appropriate masks before<br>reading host events. However, with recent change in EC to report all<br>set host events, setting of wake masks just to query the events is no<br>longer required. This change removes the setting of wake_mask before<br>and after reading the host events.<br><br>TEST=Verified that EC wake events are correctly logged.<br><br>Change-Id: Ib17e1296fb7d3bbc84fc7581fd0a9bd179ac87b9<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/ec/google/chromeec/ec.c<br>1 file changed, 0 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/22006/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c<br>index 639719a..1683a9c 100644<br>--- a/src/ec/google/chromeec/ec.c<br>+++ b/src/ec/google/chromeec/ec.c<br>@@ -245,21 +245,14 @@<br> static void google_chromeec_log_events(u32 mask)<br> {<br>  u8 event;<br>-    u32 wake_mask;<br> <br>     if (!IS_ENABLED(CONFIG_ELOG))<br>                 return;<br>-<br>-   /* Set wake mask so events will be read from ACPI interface */<br>-       wake_mask = google_chromeec_get_wake_mask();<br>- google_chromeec_set_wake_mask(mask);<br> <br>       while ((event = google_chromeec_get_event()) != 0) {<br>          if (EC_HOST_EVENT_MASK(event) & mask)<br>                     elog_add_event_byte(ELOG_TYPE_EC_EVENT, event);<br>       }<br>-<br>- google_chromeec_set_wake_mask(wake_mask);<br> }<br> <br> void google_chromeec_events_init(const struct google_chromeec_event_info *info,<br></pre><p>To view, visit <a href="https://review.coreboot.org/22006">change 22006</a>. To unsubscribe, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/22006"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib17e1296fb7d3bbc84fc7581fd0a9bd179ac87b9 </div>
<div style="display:none"> Gerrit-Change-Number: 22006 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>