[coreboot-gerrit] Change in coreboot[master]: amd/soc/common: Print and error if an AGESA callout isn't supported

[Marc Jones (Code Review)]

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/21998


Change subject: amd/soc/common: Print and error if an AGESA callout isn't supported
......................................................................

amd/soc/common: Print and error if an AGESA callout isn't supported

Let the developer or user know that a callout isn't supported.

Change-Id: I73a6c6930a6661627ad76e27bbb78be99e237949
Signed-off-by: Marc Jones <marcj303 at gmail.com>
---
M src/soc/amd/common/def_callouts.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/21998/1

diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c
index bad4f58..3e332ac 100644
--- a/src/soc/amd/common/def_callouts.c
+++ b/src/soc/amd/common/def_callouts.c
@@ -33,8 +33,12 @@
 		if (BiosCallouts[i].CalloutName == Func)
 			break;
 	}
-	if (i >= BiosCalloutsLen)
+
+	if (i >= BiosCalloutsLen) {
+		printk(BIOS_ERR, "ERROR: AGESA Callout Not Supported: 0x%x",
+			(u32)Func);
 		return AGESA_UNSUPPORTED;
+	}
 
 	return BiosCallouts[i].CalloutPtr(Func, Data, ConfigPtr);
 }

-- 
To view, visit https://review.coreboot.org/21998
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73a6c6930a6661627ad76e27bbb78be99e237949
Gerrit-Change-Number: 21998
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171012/1a352576/attachment-0001.html>